Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#354 Test cases added for Gradle and Maven #364

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Issue#354 Test cases added for Gradle and Maven #364

wants to merge 8 commits into from

Conversation

SuparnaSuresh
Copy link

@SuparnaSuresh SuparnaSuresh commented Nov 5, 2024 •
edited
Loading

Fixes #354
Added test case to handling the scenario for

  • Gradle project name with space
  • Gradle Project directory with space
  • Maven Project directory with space

@SuparnaSuresh SuparnaSuresh changed the title Issue#354 Gradle testcase project name space Issue#354 Test cases added for Gradle and Maven Nov 5, 2024
@aparnamichael
Copy link
Contributor

aparnamichael commented Nov 6, 2024 •
edited
Loading

@SuparnaSuresh

  1. Please fix the indentations.
  2. Remove unwanted spaces and unused lines of code.
  3. Run tests for 'Gradle project name' with space and 'Gradle Project directory with space' together, same as in LTI.

@SuparnaSuresh
Copy link
Author

@aparnamichael
Review comments addressed.
Made changes to run tests for 'Gradle project name' with space and 'Gradle Project directory with space' together.

aparnamichael
aparnamichael approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@aparnamichael aparnamichael self-requested a review November 8, 2024 11:24
@aparnamichael
Copy link
Contributor

This will be merged after merging issue 337 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevCraw TrevCraw Awaiting requested review from TrevCraw

@aparnamichael aparnamichael Awaiting requested review from aparnamichael

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Case for Handling Spaces in App name and Directory Name.
2 participants
@SuparnaSuresh @aparnamichael